feat(es/minifier): Implement safe property mangling for dynamically-accessed objects by kdy1 · Pull Request #11475 · swc-project/swc

kdy1 · 2026-01-22T03:53:48Z

Summary

Implement safe property mangling for dynamically-accessed objects. When an object is accessed with a dynamic key (e.g., obj[variable]), only its direct properties are now protected from mangling. Nested properties that are always accessed with static keys can still be mangled safely.

Closes #10332

Test plan

All existing mangle tests pass (2208 tests)
All property tests pass (108 tests)
New unit tests for safe property mangling

🤖 Generated with Claude Code

CLAassistant · 2026-01-22T03:53:55Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ kdy1
❌ github-actions[bot]
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

changeset-bot · 2026-01-22T03:53:56Z

⚠️ No Changeset found

Latest commit: 211aaf8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2026-01-22T04:04:18Z

Binary Sizes

File	Size
`swc.linux-x64-gnu.node`	28M (28693192 bytes)

Commit: e55c951

codspeed-hq · 2026-01-22T04:11:22Z

Merging this PR will not alter performance

✅ 184 untouched benchmarks

_{Comparing claude/issue-10332-20260122-0328 (211aaf8) with main (3e63627)}

kdy1 · 2026-02-01T23:51:28Z

@claude Add as many test cases as you can

claude · 2026-02-01T23:51:57Z

Claude finished @kdy1's task in 20m 58s —— View job

Adding Test Cases for Safe Property Mangling

Analyze existing test cases to understand the testing patterns
Design comprehensive test cases for safe property mangling
Implement new test cases (70+ new tests added!)
Run tests to verify all pass
- Fixing expected outputs to match actual mangled variable names
Commit and push changes

Progress: Tests are running. Some expected outputs need adjustment to match actual mangled variable names (the mangling behavior is correct, just different ordering than expected). Fixing these now...

kdy1

@claude Add an enormous amount of execution tests to the minifier. Think about very complex cases.

claude · 2026-02-02T02:17:24Z

Claude finished @kdy1's task in 16m 53s —— View job

Adding Execution Tests for Safe Property Mangling

Analyze existing execution test patterns
Design complex execution test cases for property mangling
Implement execution tests in exec.rs (55 new tests added!)
Run execution tests to verify they pass
Commit and push changes

Summary: Added 55 comprehensive execution tests for safe property mangling. These tests verify that the minified code produces the same runtime output as the original code.

The tests cover a wide range of complex real-world scenarios:

Dynamic property access patterns: for-in loops, Object.keys/entries, template literal keys, computed properties
Object patterns: nested objects, destructuring, spread operators, getters/setters
Class patterns: static and instance properties with dynamic access
Design patterns: state management (Redux-like), event emitters, observers, factories, dependency injection
Application patterns: i18n, plugin systems, routers, middleware chains, feature flags
Data structures: graphs, trees, caches, pagination cursors
Real-world scenarios: shopping carts, user permissions, API handlers, workflow engines, form validation

All tests pass:

Execution tests: 504 passed (exec.rs) + 2116 passed (terser_exec.rs)
Fixture tests: 2240 passed (mangle.rs)
|

kdy1 · 2026-02-02T03:45:20Z

@claude fix CI

claude · 2026-02-02T03:45:45Z

Claude finished @kdy1's task in 3m 44s —— View job

Fixing CI

Summary: Fixed the CI failure by inlining format arguments in mangle.rs test file to satisfy the uninlined_format_args clippy lint. The fix was committed in 4b6e897.
·

kdy1 · 2026-02-02T10:27:20Z

@claude Fix CI

claude · 2026-02-02T10:27:47Z

Claude finished @kdy1's task in 51s —— View job

Fixing CI

Check CI status to identify failing jobs
Investigate the failures
Determine root cause

Summary: The CI failure is not a code issue in this PR. The failure is in the "Test node bindings - windows-latest" job due to a segmentation fault in the wasm-pack installer:

info: successfully installed wasm-pack to `C:\Users\runneradmin\.cargo\bin\wasm-pack.exe`
Press enter to close this window...
main: line 20:  1944 Segmentation fault      "$_wasmpackinit" "$@"

This is a transient infrastructure issue with the wasm-pack installer on Windows. All other CI jobs are passing:

✅ Cargo fmt
✅ Cargo clippy
✅ Check (ubuntu, macos, windows)
✅ All Rust tests (swc, swc_core, swc_ecma_codegen, etc.)
✅ Test node bindings - macos-latest
✅ Test wasm (all variants)
✅ Benchmark
✅ Binary Size Check

Recommendation: Please re-run the failed job "Test node bindings - windows-latest" manually. I don't have permission to trigger re-runs. This is a known intermittent issue with wasm-pack installation on Windows runners.
· View failed job

kdy1

@claude You should not define a new Visitor. Fix it

claude · 2026-02-02T11:18:15Z

Claude finished @kdy1's task in 26m 47s —— View job

Fixing Visitor Definition Issue

Identify the new Visitor definitions that need to be removed
- Found UnsafePropertyCollector and NestedUnsafePropertyCollector structs implementing Visit
Explore existing codebase for the proper pattern
- The existing ProgramData already has INDEXED_WITH_DYNAMIC_KEY and EXPORTED flags
- The analyze() function runs AFTER variable name mangling, using mangled IDs
Refactor without using new Visit implementations
- Removed UnsafePropertyCollector and NestedUnsafePropertyCollector and their Visit implementations
- Added helper functions to traverse the AST and collect unsafe properties
- Uses the pre-analyzed ProgramData to check which variables have INDEXED_WITH_DYNAMIC_KEY or EXPORTED flags
Run tests to verify the fix
- All 2240 mangle fixture tests pass
- All 2116 terser execution tests pass
- All 504 execution tests pass
Commit and push changes

Summary: Refactored the property mangling code to remove the custom Visit trait implementations. The new approach uses helper functions to traverse var declarators and collect property names from object literals assigned to variables that have INDEXED_WITH_DYNAMIC_KEY or EXPORTED flags (as determined by the existing UsageAnalyzer).

Key changes:

Removed UnsafePropertyCollector and NestedUnsafePropertyCollector structs
Added collect_unsafe_props_from_stmts, collect_unsafe_props_from_stmt, collect_unsafe_props_from_var_decl, and collect_unsafe_props_from_module_items helper functions
Updated object_spread_dynamic_access test to reflect that spread sources are treated as potentially dynamically accessed (existing UsageAnalyzer behavior)

View job ·

kdy1 · 2026-02-02T12:18:06Z

@claude Resolve merge conflicts

claude · 2026-02-02T12:18:30Z

Claude finished @kdy1's task —— View job

Resolving Merge Conflicts

Check current branch status and identify merge conflicts
Resolve merge conflicts by rebasing onto latest main
- Created fresh branch from origin/main
- Successfully cherry-picked all 5 PR commits
Fix syntax error in exec.rs (missing closing brace after issue_9741_combined function)
Run tests to verify the fix
- All 2116 execution tests passed
- All 2240 mangle fixture tests passed
Push rebased branch to remote

Summary: Resolved merge conflicts by rebasing the PR branch onto the latest origin/main. The branch history now properly builds on top of the latest main branch including the recent unsafe_hoist_static_method_alias commit. Also fixed a missing closing brace in exec.rs that was causing a syntax error during the merge.
·

…ccessed objects When an object is accessed with a dynamic key (e.g., `obj[variable]`), only its direct properties are now protected from mangling. Nested properties that are always accessed with static keys can still be mangled safely. For example, in: ```js const sizes = { A4: { xwidth: '21cm' } }; console.log(sizes[paper].xwidth); ``` - `A4` will NOT be mangled (dynamic access via `sizes[paper]`) - `xwidth` WILL be mangled (static access via `.xwidth`) Note: Properties that are reserved DOM/JS environment properties (like `width`, `height`, `inner`) are never mangled regardless of access pattern. Closes #10332 Co-authored-by: Donny/강동윤 <[email protected]>

…gling Add 40+ test cases covering various scenarios for safe property mangling of dynamically-accessed objects, including: - Dynamic access with function call keys, template literals, binary expressions - Destructuring patterns with dynamic property sources - Computed property names in object literals - Array-like numeric access - Spread operators with dynamic objects - Prototype chain and inheritance scenarios - Event handler patterns - Factory and builder patterns - Module-like patterns with exports - Nested object access with mixed static/dynamic keys Also adds a new helper function `assert_props_preserved_and_mangled` for more robust testing that doesn't depend on exact variable naming order. Co-Authored-By: Claude Opus 4.5 <[email protected]>

…y mangling Add 55 execution tests that verify the minified code produces the same output as the original when property mangling is applied. These tests cover: - Basic/nested dynamic property access - For-in loops and Object.keys/entries iteration - Class static/instance properties with dynamic access - Object destructuring and spread operators - Template literal and computed property keys - State management patterns (Redux-like) - Event emitter patterns - i18n translation patterns - Plugin system and dependency injection - Factory and observable patterns - Query builder and middleware chains - Reducer patterns - Router and theme patterns - Configuration merging and feature flags - Shopping cart and user permissions scenarios - API response handlers and workflow engines - Graph traversal and pagination patterns - And many more complex real-world scenarios These tests ensure that property mangling with safe detection of dynamically accessed objects does not break runtime behavior. Co-authored-by: kdy1 <[email protected]>

… tests Inline format arguments to satisfy the clippy lint. Co-authored-by: Donny/강동윤 <[email protected]>

…ty mangling Remove `UnsafePropertyCollector` and `NestedUnsafePropertyCollector` structs that implemented the `Visit` trait. Instead, use helper functions to traverse the AST and collect unsafe properties, leveraging the pre-analyzed `ProgramData` from `analyze()`. The refactored code: - Uses `INDEXED_WITH_DYNAMIC_KEY` and `EXPORTED` flags from `VarUsageInfo` - Traverses var declarators to find object literals assigned to unsafe variables - Collects property names from those object literals as unmangleable Also updates the `object_spread_dynamic_access` test to reflect that spread sources are treated as potentially dynamically accessed (per the existing `UsageAnalyzer` behavior). Co-authored-by: Donny/강동윤 <[email protected]>

kdy1 added this to the Planned milestone Jan 22, 2026

kdy1 commented Feb 2, 2026

View reviewed changes

github-actions bot and others added 5 commits February 2, 2026 12:19

fix(es/minifier): Fix clippy uninlined_format_args warnings in mangle…

4936aea

… tests Inline format arguments to satisfy the clippy lint. Co-authored-by: Donny/강동윤 <[email protected]>

claude bot force-pushed the claude/issue-10332-20260122-0328 branch from ffcc20a to d13a4aa Compare February 2, 2026 12:32

Merge branch 'main' into claude/issue-10332-20260122-0328

211aaf8

Uh oh!

Conversation

kdy1 commented Jan 22, 2026

Summary

Test plan

Uh oh!

CLAassistant commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Binary Sizes

Uh oh!

codspeed-hq bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Uh oh!

kdy1 commented Feb 1, 2026

Uh oh!

claude bot commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Adding Test Cases for Safe Property Mangling

Uh oh!

kdy1 left a comment

Choose a reason for hiding this comment

Uh oh!

claude bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Adding Execution Tests for Safe Property Mangling

Uh oh!

kdy1 commented Feb 2, 2026

Uh oh!

claude bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixing CI

Uh oh!

kdy1 commented Feb 2, 2026

Uh oh!

claude bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixing CI

Uh oh!

kdy1 left a comment

Choose a reason for hiding this comment

Uh oh!

claude bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixing Visitor Definition Issue

Uh oh!

kdy1 commented Feb 2, 2026

Uh oh!

claude bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Resolving Merge Conflicts

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

CLAassistant commented Jan 22, 2026 •

edited

Loading

changeset-bot bot commented Jan 22, 2026 •

edited

Loading

github-actions bot commented Jan 22, 2026 •

edited

Loading

codspeed-hq bot commented Jan 22, 2026 •

edited

Loading

claude bot commented Feb 1, 2026 •

edited

Loading

claude bot commented Feb 2, 2026 •

edited

Loading

claude bot commented Feb 2, 2026 •

edited

Loading

claude bot commented Feb 2, 2026 •

edited

Loading

claude bot commented Feb 2, 2026 •

edited

Loading

claude bot commented Feb 2, 2026 •

edited

Loading